search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
452 stars 165 forks source link

Modelica.Magnetic.FluxTubes examples - comment from 4418 #4431

Open HansOlsson opened 4 days ago

HansOlsson commented 4 days ago

Two issues for Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceCurrentBehaviour and Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceStrokeBehaviour:

  1. I don't see why we have so short Interval (1e-4) for these two models in #4418

To me it seems 0.01 s would work as well, and if someone sets a very small Interval I expect that there is something relevant on that time-scale, and I don't know which signal. So, if there is something interesting on that time-scale, please enlighten me. (Note that Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ArmatureStroke has a small Interval since it simulates for a short time and has interesting dynamics.)

  1. The documentation is broken for those two models (and likely have been for quite some time) - it refers to flange_b for components that only have flange.

Originally posted by @HansOlsson in https://github.com/modelica/ModelicaStandardLibrary/pull/4418#pullrequestreview-2134384603

casella commented 4 days ago

@AHaumer can you please commen on that?

AHaumer commented 15 hours ago

I just compared two simulations and yes 100 ms is ok. We just have to take care of the reference results ... I'll have a look at the broken links.