search

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.
https://doc.modelica.org
BSD 3-Clause "New" or "Revised" License
470 stars 167 forks source link

Colors are wrong in annotations for Diode models (and maybe Sources too). #543

Closed modelica-trac-importer closed 7 years ago

modelica-trac-importer commented 7 years ago

Reported by stefanv on 28 Apr 2011 15:26 UTC The diode models in Modelica.Electrical.Analog.Semiconductors all have the triangular part shown in black, whereas the rest of the component (cathode bar and leads) is blue.

All of the sources under Modelica.Electrical.Analog.Sources have the circle, and the connection between the two ports, in black. Should those not also be blue, since these are electrical components?

Migrated-From: https://trac.modelica.org/Modelica/ticket/543

modelica-trac-importer commented 7 years ago

Comment by Kristin Majetta on 3 May 2011 08:30 UTC I changed the colors from black to blue in the mentioned models.

modelica-trac-importer commented 7 years ago

Comment by dietmarw on 3 May 2011 08:38 UTC The changes done (in b99392f8f0896a92fb18ad21b99d82a7cc66382c) are still missing out SignalCurrent and ConstantCurrent.

modelica-trac-importer commented 7 years ago

Comment by Kristin Majetta on 5 May 2011 11:58 UTC Colors changed in SignalCurrent and ConstantCurrent (ec9a919653a524be7bf793db704b36b6914208e9)

modelica-trac-importer commented 7 years ago

Comment by dietmarw on 6 May 2011 09:08 UTC There were still come diagram and icon views not corrected. I fixed that now for the sake of saving time. Also I noticed a lot of diagram views in the sources of Electrical.Analog and Blocks with a lot of glitches (e.g., unsymmetrical arrow heads, lines not aligned) which were probably also a result of "copy and paste". This was corrected in fe5e5762a80c910d84a49b980e703ae82deb45b8 and some more colour fixes in the mentioned semiconductors were finally applied in 3b8a5315e9207502e2a6389c69e6dde70004b1e0.

modelica-trac-importer commented 7 years ago

Modified by majetta on 5 Apr 2013 10:08 UTC

modelica-trac-importer commented 7 years ago

Changelog modified by majetta on 5 Apr 2013 10:08 UTC Wrong colours of icons in Modelica.Electrical.Analog changed