Open modelica-trac-importer opened 7 years ago
Modified by dietmarw on 18 Jan 2013 07:57 UTC
Comment by dietmarw on 1 Aug 2015 21:36 UTC Milestone renamed
Comment by dietmarw on 1 Aug 2015 21:39 UTC Milestone renamed
@rfranke Modelica.Fluid.Interfaces.PartialPressureLoss uses the names d_a
, d_b
, eta_a
and eta_b
. Same idents are also used in Modelica.Fluid.Fittings.BaseClasses.Bends.CurvedBend.{massFlowRate, pressureLoss}, Modelica.Fluid.Fittings.BaseClasses.Bends.EdgedBend.{massFlowRate, pressureLoss} and Modelica.Fluid.Fittings.BaseClasses.Orifices.ThickEdgedOrifice.{massFlowRate, pressureLoss} as function arguments. Shall they be renamed as well?
Furthermore, eta
is used in Fluid.Dissipation for dynamic viscosity. Shall it be replaced as well?
No reply from library officers -> removing milestone.
Reported by rfranke on 17 Jan 2013 19:39 UTC Modelica.Fluid generally uses the names
rho
for density andmu
for dynamic viscosity. See e.g.:The models
internally use the names
d
andeta
instead. These alternative names are not used in Fluid because:eta
is reserved for efficiency (see e.g. Pump)d
is ultimately short, complicating maintenance, and might be messed up with diameterThe uses if
d
andeta
for density and dynamic viscosity shall be replaced withrho
andmu
, respectively.Even though these names are only used internally, a renaming in MSL3.2.1 might break compatibility, e.g. for models extending from
Modelica.Fluid.Interfaces.PartialPressureLoss
.Migrated-From: https://trac.modelica.org/Modelica/ticket/966