search

modelica / VehicleInterfaces

Free (standard conforming) library for interface definitions and architectures for vehicle system modeling
Other
43 stars 22 forks source link

Enable user-friendly dialog for replaceable road function #97

Closed tobolar closed 3 years ago

tobolar commented 3 years ago

Close #89

@GarronFish Can you review this PR?

GarronFish commented 3 years ago

Yes will do.

tobolar commented 3 years ago

Some comments to your suggestion in #89:

  1. Regarding class documentation, esp. in the function trackOffset. It is of course welcome to add more documentation to clarify the intension of the class. In this case ("... driving line location relative to the road centre line", etc.), I nontheless reduced the documentation and would prefer to add this in the base functions directly, e.g. in VehicleInterfaces.Roads.Interfaces.trackOffsetBase, etc. Optionally, the tutorial section of the Road could be a good place.

  2. And, I call the corresponding tab "Road functions". I'm not so happy with it but have no better idea.

GarronFish commented 3 years ago

Yes I agree with point 1.

"Road functions" seems fine may be "Functions" is slightly better.