search

modelica / fmi-ls-struct

Layered standard for FMI for structuring of variables
Other
6 stars 3 forks source link

Review the current draft #16

Open chrbertsch opened 4 months ago

chrbertsch commented 4 months ago

from: https://github.com/modelica/fmi-design/tree/master/Meetings/2024/2024-07-16-FMI-Design-Webmeeting

TorstenBlochwitz commented 2 weeks ago

Section 3.1.2. variableKind attribute values of terminal member variables ... org.fmi-standard.fmi-ls-struct.map.domainOutput Optionally, for each domain variable at most one array variable (typically an input or a local variable) can be referenced that represents calculated output value of the map. If present, a domainOutput variable must be listed directly after the corresponding codomain variable. ... I presume this variable is typically an output or an a local variable.

TorstenBlochwitz commented 2 weeks ago

Section 4.3. Referencing Modelica library Combitables

We should use the correct name "Modelica Standard Library" instead of "Modelica library". I would propose to rename this section to something like: "Referencing Tables from the Modelica Standard Library"

TorstenBlochwitz commented 2 weeks ago

Section 4.3.1.1. Example:

According to the Documentation, the CombiTable1D has four additional parameters (columns, smoothness, extrapolation, verboseExtrapolation).

Shouldn't we list these parameters instead of the not existing parameter "interpolation"?

I addition to that, the codomainOutput should have the correct dimension, which is defined by the parameter columns.

TorstenBlochwitz commented 2 weeks ago

Section 5. Maps sampled on a irregular grid ("Point Cloud")

This section (especially the example) needs more elaboration. With the current text I don't understand the semantics.