search

modelica / fmi-standard

Specification of the Functional Mock-up Interface (FMI)
https://fmi-standard.org/
Other
274 stars 85 forks source link

Clarification that variable names must be unique #415

Closed modelica-trac-importer closed 5 years ago

modelica-trac-importer commented 6 years ago

Reported by ottot on 20 Apr 2017 06:57 UTC In 2.2.7 Definition of Model Variables (ModelVariables) there is a table where the description of the name attribute is "The full, unique name of the variable.", so there it looks well established that the name should be unique.

In 2.2.9 Variable Naming Conventions (variableNamingConvention) we have the sentence The names must be unique, non-empty strings. However it looks to be under the heading variableNamingConvention = "flat". It should either be repeated under variableNamingConvention = "structured" or moved to the top-level in 2.2.9 so that it is clear that the uniqueness requirement applies regardless of variableNamingConvention.

Migrated-From: https://trac.fmi-standard.org/ticket/415

modelica-trac-importer commented 6 years ago

Modified by aviel on 4 May 2017 06:29 UTC

modelica-trac-importer commented 6 years ago

Comment by pierre.mai on 12 Jun 2018 21:19 UTC FWIW, the full entry in section 2.2.7 reads:

The full, unique name of the variable. Every variable is uniquely identified within an FMU instance by this name or by its ScalarVariable index (the element position in the ModelVariables list; the first list element has index=1).

This seems to be fairly clear that variables must always be uniquely identified by their name, regardless of naming convention used. Might still be a good idea to clarify some more, though.

chrbertsch commented 5 years ago

Included in the merged PR #579