modelica / fmi-standard

Specification of the Functional Mock-up Interface (FMI)
https://fmi-standard.org/
Other
271 stars 85 forks source link

Check non normative text on pure discrete-time FMUs #704

Closed chrbertsch closed 4 years ago

chrbertsch commented 4 years ago

In FMI 2.0.1 we have the following non-normative text in remark 4 or section 3.1:

This is an optional optimization for the master, the FMU must support all functions that are required for a continuous time FMU and should run in a master that treats it as such. If a pure discrete time FMU has state events and uses event indicators, it has to enter continuousTimeMode to evaluate these. In fact, it is no longer a Pure Discrete time FMU but this was not clearly defined in 2.0 so this clarification is needed for 2.0.1]

Check that in FMI 3.0 we have a correction in the normative text and adapt or remove the normative text

chrbertsch commented 4 years ago

(The original issue was #409)

I consider it problematic that "pure discrete time FMU" seem to be only defined in non-normative remarks:

but then we refer to this definition in normative text (footnote of the table at the end of 3.2.3 grafik

I see the following alternatives for FMI 3.0:

I would favour the second option. Or do I miss something? Or other suggestions?

chrbertsch commented 4 years ago

FMI Design Meeting:

Torsten B: We should get rid of the remark.
If we have the continuous states or not we use the same the same state machine ... This makes it hard to check the calling sequence. Andreas J.: This is an unnecessary simplification that does not ease implementation. Torsten B: this exception breaks the logic of the state machine In the current state machine we do no longer have this shortcut.

Poll: Shall we remove the definition of "pure discrete states" and get rid of the exception in the state machine? Yes: 7 No: 0 Abstain:5

@andreas-junghanns : will fix it

andreas-junghanns commented 4 years ago

I created PR #844 to address this issue.

chrbertsch commented 4 years ago

Fixed with #844