modelica / ssp-standard

Specification of System Structure and Parameterization (SSP)
Other
12 stars 8 forks source link

New features in SSP 2.0 #40

Closed DagBruck closed 1 month ago

DagBruck commented 5 months ago

I think it would be valuable to summarize the new features in SSP 2.0 as a short bullet list. I need that internally, and it will be needed for the announcement. Maybe we can start now.

JochenKoehler commented 3 months ago

web meeting 2024-08-13: As a starting point for review (of changes / diffs): https://github.com/modelica/ssp-standard/releases/tag/untagged-a425b2e7f63c982b9ef3 New pull request should be created with the "extended" bullet list from above.

robha67 commented 1 month ago

@pmai I am trying to push the minor changes I made to the branch that you created but I am running into problems. I get the error "permission to modelica/ssp-standard.git denied to robha67." Do I have the correct access rights?

robha67 commented 1 month ago

@pmai I cannot find any pull request that allows for, for example, arrays in SSV files. Was that added to the 2.0 specification?

pmai commented 1 month ago

@pmai I cannot find any pull request that allows for, for example, arrays in SSV files. Was that added to the 2.0 specification?

PR #8 contains commit 2d4b9460 that adds the array capabilities to SSV.

pmai commented 1 month ago

@pmai I am trying to push the minor changes I made to the branch that you created but I am running into problems. I get the error "permission to modelica/ssp-standard.git denied to robha67." Do I have the correct access rights?

From the access rights point of view you should be able to push to the ssp-standard repo, so it should work to push new commits on top of the current branch. If it does not work out for you, you might want to see if pushing to your own fork of ssp-standard works...

robha67 commented 1 month ago

Ok, thank you for checking. I will investigate further on my end towards the end of this week

robha67 commented 1 month ago

@pmai just to avoid any further confusion. Should the text be added to 1overview.adoc instead of the 0preamble.adoc?

pmai commented 1 month ago

@pmai just to avoid any further confusion. Should the text be added to 1overview.adoc instead of the 0preamble.adoc?

Yes, that is the idea; I have now consolidated the two sets of descriptions somewhat, tightened up the language to avoid future or past-looking statements, and added some related changes to the PR/branch, which can now serve as a basis for your further changes.

robha67 commented 1 month ago

@pmai Again, just to be sure, the PR branch is "maint/add-20-changes"?

pmai commented 1 month ago

@pmai Again, just to be sure, the PR branch is "maint/add-20-changes"?

Yes.

Hans-Martin-Heinkel commented 1 month ago

Checked the text, no additional comments from my side

pmai commented 1 month ago

Closed via #43