search

modelmapper / modelmapper-module-java8

ModelMapper Module for Java8
Apache License 2.0
14 stars 15 forks source link

Implement Optional To Optional Converter #6

Closed schnapster closed 4 years ago

schnapster commented 4 years ago

Ahoy,

this PR implements an optional-to-optional converter based on https://github.com/modelmapper/modelmapper/issues/135

chhsiao90 commented 4 years ago

Hi @napstr,

The pull request looks good to me, and I'm going to merge the branch after the build succeed. The travisci build issue was fixed in #7, can you help to rebase master branch? Thansk!

schnapster commented 4 years ago

@chhsiao90 great job on fixing the build. Rebase done & build is green.

chhsiao90 commented 4 years ago

Thanks for the contribution!

schnapster commented 4 years ago

It was a pleasure. @chhsiao90 any chance this could be released?

chhsiao90 commented 4 years ago

I will have a release next Monday!

chhsiao90 commented 4 years ago

v1.1.0 just released!

schnapster commented 4 years ago

@chhsiao90 Ahoy, I cannot find the v1.1.0 on maven central - can you please double-check?

chhsiao90 commented 4 years ago

I can't see it either... It should be deployed to staging server successfully. I will check it! Thanks for the reminder.

chhsiao90 commented 4 years ago

Hi @napstr ,

I just re-released it, please take a look, thanks.

https://search.maven.org/artifact/com.github.chhsiao90/modelmapper-module-java8/1.1.0/pom

schnapster commented 4 years ago

Thank you, can confirm it is available now.