search

modelmat / sphinxcontrib-drawio

Sphinx extension for including draw.io files.
MIT License
39 stars 17 forks source link

add option to select to move the output to the sphinx output directory #52

Closed prozessorkern closed 3 years ago

prozessorkern commented 3 years ago

We would like to use this module for our sphinx documentation. To be able to clean the project using our buildsystem and to keep the sourcedirectory clean we'd like to have the generated files in the sphinx output directory.

This might be a fix for #50

I tried to implement this as an option and added a section to the README and a testcase.

What do you think?

modelmat commented 3 years ago

Seems mostly fine.

As we're going to start using black to format code, could you please run it? It seems you have changes in here which don't affect the actual running but just the formatting.

Also, it's been a while since I've properly used this, but I thought this already exported the images into the build/... directory? (Which I thought was the outdir?)

modelmat commented 3 years ago

Please don't commit .vscode files.

brechtm commented 3 years ago

Thanks for your patience, @prozessorkern. The review process does make contributing take quite a bit more effort, but I feel it really helps to improve quality.

brechtm commented 3 years ago

Just a heads-up. A solution for #55 might obsolete the need for a .drawio directory. I'll give an update when I know more.

modelmat commented 3 years ago

@brechtm If you could get back w/r/t the solution for #55, that'd be great.

I think at the moment I would like to get this merged so that the issues-as-is are resolved; so @prozessorkern if you could fix up the few remaining documentation issues, that'd be great, thanks :)

brechtm commented 3 years ago

@brechtm If you could get back w/r/t the solution for #55, that'd be great.

I worked out a prototype before the holidays. I new cleaned things up for PR #58. Please review.

prozessorkern commented 3 years ago

Sorry for the quite long delay - I had some busy last weeks :(

...I hope I now fixed the remaining Issues. (even if it is not needed anymore)