search

modelmat / sphinxcontrib-drawio

Sphinx extension for including draw.io files.
MIT License
39 stars 17 forks source link

Fix #60 by converting the pathlib.Path object to str #61

Closed modelmat closed 3 years ago

modelmat commented 3 years ago
modelmat commented 3 years ago

It's not immediately obvious what the effect is of using both the drawio and imgconverter extensions. Perhaps it's good to explain exactly what happens in a comment?

I'm assuming sphinxcobtrib-drawio first converts to SVG and imgverversion converts to PNG afterwards?

Yep. I did add a comment in the test but I appear to have written "but" and not "by".