search

modelmat / sphinxcontrib-drawio

Sphinx extension for including draw.io files.
MIT License
39 stars 17 forks source link

Figure out why pypi releases do the release but then fail #73

Closed modelmat closed 9 months ago

modelmat commented 2 years ago

It seems to be uploading the release twice? No idea why

Milacus commented 1 year ago

Maybe this helps to analyze the problem

jdillard commented 9 months ago

I'm not sure, but my guess is it is related to the triggers:

https://github.com/modelmat/sphinxcontrib-drawio/blob/373b54f179b19a0a6dee2493e9333811869210cb/.github/workflows/workflow.yml#L2-L13

Because the workflow sometimes runs several times for single commit, for example when I pushed and tagged https://github.com/modelmat/sphinxcontrib-drawio/commit/373b54f179b19a0a6dee2493e9333811869210cb:

image source: https://github.com/modelmat/sphinxcontrib-drawio/actions

In this case, it one is a create event and the other two are push events (one push event isn't tagged, so doesn't trigger a release). So I'm thinking maybe the create tag event is in a race event with the push tag event and the fix is to only trigger tags on push or create (not sure best practice).