modelmat / sphinxcontrib-drawio

Sphinx extension for including draw.io files.
MIT License
39 stars 17 forks source link

Use release/v1 of gh-action-pypi-publish #94

Closed jdillard closed 1 year ago

jdillard commented 1 year ago

To fix the publish step warning:

Warning:  You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.

Per the docs: https://github.com/pypa/gh-action-pypi-publish#-master-branch-sunset-

It also looks like using user/pass is deprecated and needs to switch using a token at some point:

Warning: Input 'user' has been deprecated with message: UNSUPPORTED GITHUB ACTION VERSION
Warning: Input 'password' has been deprecated with message: UNSUPPORTED GITHUB ACTION VERSION

Docs: https://github.com/pypa/gh-action-pypi-publish#trusted-publishing

jdillard commented 1 year ago

I originally thought this was an error preventing the publish step from happening, but it turns out it is just a warning for now.

@modelmat not sure if you want to change the user/pass out for a token at some point before the user/pass is fully deprecated. I'll leave this open for visibility for now, but it might be worth merging this and just parking the "change the user/pass out for a token" as an open issue.

In other news, 0.0.17 is out! :tada:

modelmat commented 1 year ago

I'm pretty sure it's already a token, the username is specified as __token__. They might have changed how you should be specifying tokens instead of via that method?

image

jdillard commented 1 year ago

Ah ok, I see. Maybe UNSUPPORTED GITHUB ACTION VERSION is the key issue there.