modelmat / sphinxcontrib-drawio

Sphinx extension for including draw.io files.
MIT License
39 stars 17 forks source link

Fix action events for tagging releases #95

Closed jdillard closed 1 year ago

jdillard commented 1 year ago

This should fix https://github.com/modelmat/sphinxcontrib-drawio/issues/73

I don't think the create event trigger is actually being used and it seems you can rely on just the push event trigger.

I also added a check for the push event as an extra precaution for any future changes, per the docs:

A common use case is to upload packages only on a tagged commit, to do so add a filter to the job:

if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')

source: https://github.com/marketplace/actions/pypi-publish

If desired, I could revert the commit that removes the create event trigger, as the push event check is in place.