search

modelon-community / Assimulo

Assimulo is a simulation package for solving ordinary differential equations.
https://jmodelica.org/assimulo/index.html
GNU Lesser General Public License v3.0
66 stars 16 forks source link

Unpin scipy upper version limit #101

Closed jschueller closed 2 weeks ago

jschueller commented 2 weeks ago

Rationale: It works fine with 1.13 and with have no indication that something will break with the next minor versions (and no major version bump in sight)

PeterMeisrimelModelon commented 2 weeks ago

This was not due to any issues in Assimulo directly, but we did detect a regression in PyFMI with scipy 1.13.0. From the initial investigation we could not yet rule out that Assimulo might be affected (or that the root cause is within Assimulo).

We have not had the time to dig deeper into this yet. It is not clear what caused the regression based on the scipy changelog alone.

jschueller commented 2 weeks ago

Well tests also pass at pyfmi with scipy 1.13 so the pinning can be dropped at least here Also I think it can be dropped at the pyfmi level since everything is ok: https://github.com/modelon-community/PyFMI/pull/243