search

modelon-community / Assimulo

Assimulo is a simulation package for solving ordinary differential equations.
https://jmodelica.org/assimulo/index.html
GNU Lesser General Public License v3.0
70 stars 17 forks source link

Fix build with sundials 7 #94

Closed jschueller closed 6 months ago

jschueller commented 6 months ago

Could you review this one @modelonrobinandersson / @PeterMeisrimelModelon ? It fixes several issues for building with sundials 7.x Also fixes the cvode NULL pointer bug shown by the tests and the nfcnjacs number test (see IDAGetNumLinResEvals)

jschueller commented 6 months ago

would it be possible to have a new release after that ? it would ease packaging for conda etc

jschueller commented 6 months ago

@modelonrobinandersson done, and added one last commit to fix latex formulas escape (avoids SyntaxWarning)

modelonrobinandersson commented 6 months ago

@modelonrobinandersson done, and added one last commit to fix latex formulas escape (avoids SyntaxWarning)

looks good to me!

jschueller commented 6 months ago

good for you too @PeterMeisrimelModelon ?