search

modelsbuilder / ModelsBuilder.Original

The Community Models Builder for Umbraco
MIT License
114 stars 49 forks source link

Shadow inherited interface properties for compositions #123

Open lars-erik opened 7 years ago

lars-erik commented 7 years ago

We do a lot of "common interfaces" outside the Umbraco Site assembly. Most compositions inherit these interfaces, and they match in names so we don't have to do more than add a partial with the inheritance. However, all generated properties of course report that they hide and should have the new keyword. Adding the new keyword to all props of course adds a warning that there is nothing to shadow for those that are specific to the site. Since MB already does some analysis on existing code, would it be possible to check inherited interfaces and add the new keyword to any property that matches?

(Slight duplicate of #70)

zpqrtbnk commented 7 years ago

Probably, will need to do it ;-)

lars-erik commented 7 years ago

:)

I'd PR it, but have to land 15 other balls first.