Closed nightblure closed 2 months ago
@nightblure looks great, thanks!
we lose coverage on this line after I removed omit. is it acceptable to add # pragma: no cover
here?
we lose coverage on this line after I removed omit. is it acceptable to add
# pragma: no cover
here?
yes, it's ok
thanks for the review! corrected according to your comments, please take a look
hmm, there is still a question about updating the documentation. I can try to add the relevant sections myself if you allow, or you will do this
@nightblure would be great if you'll add docs as well, but it's up to you. Anyway, thank you for your contribution!
@nightblure would be great if you'll add docs as well, but it's up to you. Anyway, thank you for your contribution!
ok I'll try to do it. within the current MR or separate?
@nightblure better in separate, I'll merge this
I implement two little features for ease of use during tests:
new way
with some_provider.override_context(mock): ...