search

modernatx / seqlike

Unified biological sequence manipulation in Python
https://modernatx.github.io/seqlike
Apache License 2.0
207 stars 21 forks source link

Ensure that translate() generates correct seqnums letter_annotations #21

Closed ndousis closed 3 years ago

ndousis commented 3 years ago

SeqLike.translate() now yields a SeqLike as if initialized from scratch (i.e., letter_annotations["seqnums"] is populated). Updated the tests, all tests pass.

Closes #20

ericmjl commented 3 years ago

@ndousis can I double-check my understanding here? Previously, .translate() did not return a SeqLike with seqnums; now it will -- is that correct?

EDIT: I think I get it now. Sorry, I should have sat down and carefully reviewed the PR earlier on before commenting!

If so, that's an awesome bugfix, thanks for the catch! I think we should do one more thing as well: Can you update the changelog with your contribution under the "unreleased" section? The following line and format should do the trick:

- Ensure that `.translate()` generates a SeqLike with "seqnum" letter annotations (@ndousis)

It'll ensure that every contribution made by PR is captured in the CHANGELOG.md file.

Once we're done, I'll merge & cut a new release ASAP.

ericmjl commented 3 years ago

@ndousis merged! New patch release will be cut shortly.