Closed JacobHayes closed 2 years ago
Hi @JacobHayes, my many apologies for responding late here! I've just seen the code changes and everything looks good from my view. I think we can merge and cut a new release as soon as all tests pass. Thank you for taking the time to help us make SeqLike better! :smile:
Things are only failing at building notebooks as docs, but everything else should be fine here. I'm going to merge.
I had a couple import errors (see below) when testing this package out that are related to undeclared dependencies in
setup.py
. Some were inrequirements.txt
, but not declared insetup.py
'sinstall_requires
, so I moved them all tosetup.py
and removedrequirements.txt
(so this doesn't happen again :crossed_fingers:).I also added 2 extras:
seqlike[test]
: this has thepytest*
deps (which I removed from the maininstall_requires
)seqlike[notebook]
: addsbokeh
, which is (currently) required when using ipython/jupyter (I think there were some refactors to make bokeh a lazy import, but it is still imported eagerly/required in notebooks)Here are the errors I saw: