moderndive / ModernDive_book

Statistical Inference via Data Science: A ModernDive into R and the Tidyverse

https://www.moderndive.com/

Other

759 stars 491 forks source link

fix: error in xhtml content of epub #461

Closed rohitvishwakarma1819 closed 9 months ago

rohitvishwakarma1819 commented 2 years ago

Prerequesite PR

https://github.com/moderndive/ModernDive_book/pull/460

After building the book to epub there were some minor issues in the xhtml content of the epub so this PR fix those errors.

ismayc commented 2 years ago

Since knitr::is_html_output() is also activated here, there are some subtle references in the EPUB that will also need to be tweaked so that language like "the website" doesn't appear in the EPUB. I'll keep looking into this and your other changes to make sure they work across modalities (PDF/LaTeX, gitbook, and epub). Thanks for your contribution and I'll keep you posted!

rohitvishwakarma-sf commented 2 years ago

Thanks @ismayc

Also I found that in the git:book build there are some css and .js files generated inside libs folder by multiple packages, but the same is missing in epub build. Even the html document structure is different in epub. Any idea on what should be the approach to fix that ?

ismayc commented 2 years ago

Working with an epub is really far outside my wheelhouse. It's one reason we avoided adding it in here. I'm not sure how much work has been done beyond what's in the bookdown documentation either to make sure the conversion works across modalities.