Closed jacobusmmsmit closed 5 months ago
can you fix the conflicts with main to see if it builds remotely?
Error comes from trying to display a static array. Weird.
I would open a Xranklin issue?
It's worked for us in the past, I suppose :')
@gdalle @adrhill things that need to be fixed before merge:
#hideall
at the top of the page? It's not hiding the output.@benchmark
have a return value and so they don't print the pretty graph when the code is run.Macros like @benchmark have a return value and so they don't print the pretty graph when the code is run.
Maybe this here is the answer? https://franklinjl.org/code/#inserting_the_output
Specifically the \show
part
I don't know what I'm doing wrong but I can't make that work :/
Even using the example from the page I get:
┌ Warning: Command '\output' used before it was defined.
└ @ Xranklin ~/.julia/packages/Xranklin/6wt1L/src/convert/markdown/latex_objects.jl:62
Maybe it's different in Xranklin than Franklin?
I took care of the #hideall
Working on the review, made my way to the end of "benchmarking"
PR remade to avoid dealing with merge conflicts in things unrelated to new content.
This PR currently covers the basic principles of writing fast-running code (minimise allocations and ensure type stability), along with a bit of why these are the principles. As well as this, it explains how (and why) to use BenchmarkTools.