search

moderntribe / square-one

Modern Tribe's legacy WordPress framework for the classic editor.
GNU General Public License v2.0
89 stars 20 forks source link

Remove Configure SMTP plugin #1033

Closed tarecord closed 2 years ago

tarecord commented 2 years ago

What does this do/fix?

On a current project Configure SMTP throws errors with every request and ends up triggering the Whoops UI, making local development a pain. This swaps that plugin (which was last updated 11 years ago) with a plugin that is actively maintained and offers a lot of functionality.

ChrisMKindred commented 2 years ago

@tarecord I like that configure SMTP doesn't try to throw a pro version in your face or take up space in the main WP Nav. What is the error that is getting thrown?

dpellenwood commented 2 years ago

Just a thought...do we need to require a SMTP plugin by default in SquareOne?

ChrisMKindred commented 2 years ago

@dpellenwood Just a thought...do we need to require a SMTP plugin by default in SquareOne?

No

defunctl commented 2 years ago

Just a thought...do we need to require a SMTP plugin by default in SquareOne?

Probably not, nope.

tarecord commented 2 years ago

Just a thought...do we need to require a SMTP plugin by default in SquareOne?

That's what I'm thinking. I figured having a concrete PR to bubble up discussion would be good :)

@ChrisMKindred I'm seeing this when its activated:

Declaration of c2c_ConfigureSMTP::options_page_description() should be compatible with C2C_Plugin_023::options_page_description($localized_heading_text = '')

@dpellenwood if I pull out the default, do we have a list of recommended SMTP plugins?

dpellenwood commented 2 years ago

@dpellenwood if I pull out the default, do we have a list of recommended SMTP plugins?

I generally point clients to their hosting provider's recommendation for email/SMTP. Here is Pantheon's and WP Engine's. In short, (in order of recommendation), I would say:

  1. MailGun or another provider which supports API-based connections
  2. WP Mail SMTP for a true SMTP connection. (Recommended by both Pantheon & WPE.)
dpellenwood commented 2 years ago

Let's just remove the plugin. Each site has its own unique email needs (MailGun, SMTP, Hosting requirements, etc...), and the decision should be based on that. We also have documentation that provides a list of plugins we recommend using for those situations.

@tarecord , curious if you'd have a chance to get back to this update the PR to remove this plugin from our default composer?

tarecord commented 2 years ago

@tarecord, curious if you'd have a chance to get back to this update the PR to remove this plugin from our default composer?

@dpellenwood, this should be good to go now.