[SQONE-710] Bugfixes from Smoketest - Githubissues

moderntribe / square-one

Modern Tribe's legacy WordPress framework for the classic editor.

GNU General Public License v2.0

89 stars 20 forks source link

[SQONE-710] Bugfixes from Smoketest #1034

Closed LayaTaal closed 2 years ago

LayaTaal commented 2 years ago

What does this do/fix?

This PR addresses a number of minor bugs found during recent smoketesting. Details around those fixes can be found in the spreadsheet here.

QA

Links to relevant issues

Link to Issue

Links to deployed, scaffolded demo:

Link to Demo

Screenshots/video

ACF Gallery Field Updates

Before: http://p.tri.be/3STntT
After: http://p.tri.be/LAC2yy

Links Block

Tests

Does this have tests?

[ ] Yes
[x] No, this doesn't need tests because...
[ ] No, I need help figuring out how to write the tests.

LayaTaal commented 2 years ago

LGTM Jason. Thanks for tackling these. The gallery one makes sense, considering the restrictions in the inspector panel for blocks. The link block I'm not all that familiar with so the issues with the Link_Header I'll defer to others for confirmation.

@Vinsanity just to clarify the removal of Link_Header is because there is no mention of it in the designs, so it wasn't quite clear to @dpellenwood and I why it was included. If someone else has more insight on this, I can definitely add it back in.