moderntribe / square1-global-docker

SquareOne Global Docker is a command line application that provides a local development environment for projects based on the SquareOne Framework.
GNU General Public License v2.0
7 stars 1 forks source link

Incorrect directory for macOS resolvers #32

Closed jbrinley closed 3 years ago

jbrinley commented 4 years ago

Describe the bug macOS DNS resolvers are in the directory /etc/resolver/. This is looking in /etc/resolvers/

After changing the path at https://github.com/moderntribe/square1-global-docker/blob/04639abd1fbcf1fc9fd64e3d7bde8b94bc76f946/app/Services/Docker/Dns/Factory.php#L87 I was able to proceed.

System Configuration:

Additional context

$ sodev global:start
★ Starting migration!
★ Backing up data in /Users/jbrinley/.config/squareone
★ Copying updated /Users/jbrinley/.config/squareone/global/docker-compose.yml
★ Copying updated /Users/jbrinley/.config/squareone/global/mysql/mysql.cnf
➜ Starting global docker containers...
DNS resolvers not enabled! Enter your sudo password when requested to enable them...
Password:

   Symfony\Component\Process\Exception\ProcessFailedException

  The command "echo "nameserver 127.0.0.1" | sudo tee /etc/resolvers/tribe" failed.

Exit Code: 1(General error)

Working directory: /Users/jbrinley/s1

Output:
================
nameserver 127.0.0.1

Error Output:
================
tee: /etc/resolvers/tribe: No such file or directory

  at vendor/titasgailius/terminal/src/Response.php:58
    54|         if ($this->successful()) {
    55|             return $this;
    56|         }
    57|
  > 58|         throw new ProcessFailedException($this->process());
    59|     }
    60|
    61|     /**
    62|      * Check if the process ended successfully.

  1   app/Services/Docker/Dns/Resolvers/ResolvConf.php:80
      TitasGailius\Terminal\Response::throw()

  2   app/Services/Docker/Dns/Resolvers/ResolvConf.php:72
      App\Services\Docker\Dns\Resolvers\ResolvConf::addNameservers()

$ ls /etc/resolver/
tribe
defunctl commented 4 years ago

Fixed in https://github.com/moderntribe/square1-global-docker/pull/30/commits/ac7f68b5156fbb3920ae928865c311f8614cfac1

jbrinley commented 3 years ago

Fixed