moderntribe / square1-global-docker

SquareOne Global Docker is a command line application that provides a local development environment for projects based on the SquareOne Framework.
GNU General Public License v2.0
7 stars 1 forks source link

dirname() expects parameter 1 to be string #90

Closed mariacdadalt closed 2 years ago

mariacdadalt commented 2 years ago

Describe the bug When so start fails, every so command returns an error.

To Reproduce 1) edit the composer.json of the project and make a mistake, for instance, forget a comma in the required list. 2) so start 3) fix the composer.json 4) try running so composer update, so restart or so stop

Expected behavior Be able to run the commands after fixing the mistake in the composer file.

Actual behavior The error:

In Config.php line 108:

  dirname() expects parameter 1 to be string, bool given  

System Configuration:

Additional context When running the so start I get the following error:

  [Seld\JsonLint\ParsingException]                                  
  "./composer.json" does not contain valid JSON                     
  Parse error on line 103:                                          
  ...dgrid": "2.1.0",  },  "minimum-stabil                          
  --------------------^                                             
  Expected: 'STRING' - It appears you have an extra trailing comma  
defunctl commented 2 years ago

@mariacdadalt this error is just passed through from composer itself.

Try bypassing so with so shell and run composer directly from the container.

defunctl commented 2 years ago

Ahh I see it also throws and error in so itself.

defunctl commented 2 years ago

Closing this, unable to reproduce and haven't had any other reports and have to assume this was a trailing comma in the composer.json it was being run on.