search

moderntribe / square1-global-docker

SquareOne Global Docker is a command line application that provides a local development environment for projects based on the SquareOne Framework.
GNU General Public License v2.0
7 stars 1 forks source link

Release/5.5.0 #94

Closed defunctl closed 2 years ago

defunctl commented 2 years ago

Adds docker compose (v2) support.

docker compose exec in v2 when using a tty is still broken.

Likely Related Issues:

Solving this by not using docker compose exec or docker-compose exec and instead using the straight docker exec, taking DC out of the equation. All existing DockerCompose exec commands have been replaced with the new Docker proxy command.

This is step one in implementing Mutagen support down the road for Mac user performance.

Testing

I'm unable to test the situation on a Mac where it's automatically enabled, so I'll need help with that, please.

One can test manually by editing squareone.yml in your SquareOne project and adding:

docker:
  compose-binary: "docker compose"
nickpelton commented 2 years ago

Testing:

Ran various combinations of tests. Looks like it works in all scenarios, so old projects only need to be updated to remove that warning, but still work fine as is.

Scenario # 1: All the new stuff, but with composer v1

Tools: sodev 5.5 + composerv1 on squareone/feature/docker-compose-v2 Outcome: PASS

Scenario # 2: All the new stuff.

Tools: sodev 5.5 + composerv2 on squareone/feature/docker-compose-v2 Outcome: PASS

Scenario # 3: New so, but composer v1 and current SQ1

Tools: sodev 5.5 + composerv1 on squareone/main Outcome: PASS

Scenario # 4: New so and composer v2, but current SQ1

Tools: sodev 5.5 + composerv2 on squareone/main Outcome: PASS, but got the WARN[0000] network proxy... notice. I assume this is expected.