fix: Fixes ObjectPropertyList double return issue

[kamronbatman]

Summary

• Fixes double return issue with object property list that is causing corruption.
• Adds DEBUG_ARRAYPOOL define constant which will crash on double return or invalid return scenarios.

[!IMPORTANT] Developer Notes STArrayPool rented arrays MUST NOT be returned ONLY ONCE otherwise there will be corruption from double-use. Use DEBUG_ARRAYPOOL to test potential broken STArrayPool use cases.

[!NOTE] Why can't I enable the debug all the time? Other than the fact that it will crash due to bad code, the actual tracking system is highly detrimental/problematic for performance and memory consumption by creating objects that have a stack trace.

[github-actions[bot]]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Detected 20 dependencies

# Third-party software list This page lists the third-party software dependencies used in ModernUO | Dependency | Version | Licenses | |------------------------------------------------------------------------------------------------------|-----------|-----------------------------------------------------------------| | [Argon2.Bindings](https://github.com/modernuo/Argon2.Bindings) | 1.16.1 | [MIT](http://opensource.org/licenses/mit-license.php) | | [BouncyCastle.Cryptography](https://www.bouncycastle.org/stable/nuget/csharp/website) | 2.4.0 | [MIT](http://opensource.org/licenses/mit-license.php) | | [CommunityToolkit.HighPerformance](https://github.com/CommunityToolkit/dotnet) | 8.3.2 | [MIT](http://opensource.org/licenses/mit-license.php) | | [LibDeflate.Bindings](https://github.com/modernuo/LibDeflate.Bindings) | 1.0.2.120 | [GPL-3.0-only](http://www.gnu.org/licenses/gpl-3.0.html) | | [MailKit](http://www.mimekit.net/) | 4.7.1.1 | [MIT](http://opensource.org/licenses/mit-license.php) | | [Microsoft.Extensions.FileSystemGlobbing](https://dot.net/) | 8.0.0 | [MIT](http://opensource.org/licenses/mit-license.php) | | [MimeKit](https://www.mimekit.net/) | 4.7.1 | [MIT](http://opensource.org/licenses/mit-license.php) | | [ModernUO.CodeGeneratedEvents.Annotations](https://github.com/modernuo/CodeGeneratedEvents) | 1.0.0 | [GPL-3.0-only](http://www.gnu.org/licenses/gpl-3.0.html) | | [ModernUO.CodeGeneratedEvents.Generator](https://github.com/modernuo/CodeGeneratedEvents) | 1.0.3.2 | [GPL-3.0-only](http://www.gnu.org/licenses/gpl-3.0.html) | | [ModernUO.Serialization.Annotations](https://github.com/modernuo/SerializationGenerator) | 2.9.1 | [GPL-3.0-only](http://www.gnu.org/licenses/gpl-3.0.html) | | [ModernUO.Serialization.Generator](https://github.com/modernuo/SerializationGenerator) | 2.11.3 | [GPL-3.0-only](http://www.gnu.org/licenses/gpl-3.0.html) | | [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) | 3.6.143 | [MIT](http://opensource.org/licenses/mit-license.php) | | [PollGroup](https://github.com/modernuo/PollGroup) | 1.5.1 | [BSD-3-Clause](http://www.opensource.org/licenses/BSD-3-Clause) | | [Serilog.Sinks.Async](https://serilog.net/) | 2.0.0 | [Apache-2.0](http://www.apache.org/licenses/) | | [Serilog.Sinks.Console](https://github.com/serilog/serilog-sinks-console) | 6.0.0 | [Apache-2.0](http://www.apache.org/licenses/) | | [Serilog](https://serilog.net/) | 4.0.1 | [Apache-2.0](http://www.apache.org/licenses/) | | [System.Formats.Asn1](https://dot.net/) | 8.0.1 | [MIT](http://opensource.org/licenses/mit-license.php) | | [System.IO.Hashing](https://dot.net/) | 8.0.0 | [MIT](http://opensource.org/licenses/mit-license.php) | | [System.Security.Cryptography.Pkcs](https://dot.net/) | 8.0.0 | [MIT](http://opensource.org/licenses/mit-license.php) | | [Zstd.Binaries](https://github.com/modernuo/Zstd.Bindings) | 1.6.0 | [MIT](http://opensource.org/licenses/mit-license.php) |

Contact Qodana team

Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions