modernuo / ModernUO

Ultima Online Server Emulator for the modern era!
https://www.modernuo.com
GNU General Public License v3.0
253 stars 154 forks source link

Update Regen Rates & Transformation Spell #365

Open kamronbatman opened 3 years ago

kamronbatman commented 3 years ago

Looks like the only reason a transformation spell uses a timer is because of LichForm. This can be rolled into regen rates directly, where a negative value (as appropriate), decrements health.

This would also eliminate the need for a timer altogether with TransformationSpells.

Looks like these conditions are checked on the timer, so they would need to be moved somewhere else too: https://github.com/modernuo/ModernUO/blob/d73afdba8eaf1b4233c722b760838f3465a5cc1b/Projects/UOContent/Spells/Base/SpellHelper.cs#L1462-L1472

kamronbatman commented 3 years ago

This might need more investigation on OSI, since it appears that on RunUO, you lose and simultaneously gain health separately. Should find out if this happens on OSI, or if the negative points and positive points are rolled in, and if the final amount is negative, you lose that many points (instead of gain) over 10 seconds.