search

modernweb-dev / rocket

The modern web setup for static sites with a sprinkle of JavaScript
https://rocket.modern-web.dev
MIT License
368 stars 51 forks source link

chore: bump dependency rehype-stringify for latest hast-util-to-html #373

Closed jorenbroekema closed 2 years ago

jorenbroekema commented 2 years ago

So, I've got a complicated issue. I have two major installations of hast-util-to-html, the old one is bugged and CJS, the new one is ok and ESM.

The old one is installed as a consequence of installing @mdjs/core --> rehype-stringify (old), the new one as a consequence of astro --> @astrojs/markdown-remark --> rehype-stringify (new).

Now, when launching my app that uses both Astro and MDJS, I'm getting CJS/ESM incompatibility issues because one installation is CJS and the other is ESM and it confuses Vite massively :P so I figured, perhaps I could nudge this "fix" in by upgrading the dependency in MDJS? Perhaps it would be even better to convert this package to ESM entirely, if possible, let me know what you think.

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 2f116a3d512c1dd1803b7f6aa636f7388f046c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | @mdjs/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

daKmoR commented 2 years ago

we will solve this by converting mdjs itself to esm and using all the latest esm dependencies... I heard someone already has a PR for that 😬