search

modernweb-dev / rocket

The modern web setup for static sites with a sprinkle of JavaScript
https://rocket.modern-web.dev
MIT License
368 stars 51 forks source link

feat(@mdjs/core): move to ESM #374

Closed jorenbroekema closed 2 years ago

jorenbroekema commented 2 years ago

What I did

  1. Move @mdjs/core to ESM
  2. Small type fix in engine
  3. Small typeof bug in building-rollup
  4. Refresh to a new yarn lock file as the old one was messy and causing some redundant nested node_modules for certain dependencies (even though semver compatible..), causing type incompatibility issues, hopefully I didn't break anything else with that
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: bf6a66bfefacd5ec831ddf8d038b2e1f55821fe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ----------------------- | ----- | | @rocket/engine | Patch | | @mdjs/core | Minor | | @rocket/building-rollup | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

daKmoR commented 2 years ago

huh... because the next branch is no more... I can not reopen this and change it's target to "main" 🤦‍♂️

can you open a new PR directly to "main"? 🙏