modernweb-dev / rocket

The modern web setup for static sites with a sprinkle of JavaScript
https://rocket.modern-web.dev
MIT License
368 stars 51 forks source link

Crash on navigation in dev mode in 'next' branch #375

Closed petecarapetyan closed 2 years ago

petecarapetyan commented 2 years ago

next branch

This rocket-03-minimal instance with dozen or so nested .md files crashes on navigation quite reliably, at least in development mode.

https://github.com/petecarapetyan/rocket_nav_iteration

Guessing it probably wouldn't crash in deployed production but will test separately.

To replicate:

Result:

FATAL ERROR: v8::FromJust Maybe value is Nothing.
 1: 0x10e548815 node::Abort() (.cold.1) [/Users/petecarapetyan/.volta/tools/image/node/16.13.2/bin/node]
 2: 0x10d247b09 node::Abort() [/Users/petecarapetyan/.volta/tools/image/node/16.13.2/bin/node]
 3: 0x10d247c7f node::OnFatalError(char const*, char const*) [/Users/petecarapetyan/.volta/tools/image/node/16.13.2/bin/node]

and the shell simply exits

petecarapetyan commented 2 years ago

As expected, does not happen on a production site, only in dev mode

petecarapetyan commented 2 years ago

Hah! Now I cannot replicate this bug - though no changes on my side would have affected this???

I am not closing the bug but it may be intermittent.

GreenJimmy commented 2 years ago

I am getting it too, picked rocket-01-hydration-starter from npx, did an npm install then start and it wont start at all

daKmoR commented 2 years ago

thanks for letting me know how you encountered the issue... I could now finally reproduce it consistently even via a test šŸŽ‰

Seems a complex one but having a failing test is half the battle - so off to the debug corner it is - wish me luck šŸ˜¬

daKmoR commented 2 years ago

ah yes, that was an interesting one... two web workers writing to the same file at the same time in parallel šŸ™ˆ let's hope something like this never returns šŸ˜…

It's fixed now via @rocket/engine@0.2.4 and I tested it with the hydration starter - which works fine now šŸŽ‰

thanks again for reporting this - if there are any more bugs be sure to report them... it's bug hunting season šŸ˜¬