modernweb-dev / rocket

The modern web setup for static sites with a sprinkle of JavaScript
https://rocket.modern-web.dev
MIT License
368 stars 51 forks source link

Fix for issue 432 #433

Open petecarapetyan opened 2 years ago

petecarapetyan commented 2 years ago

What I did

  1. create a const for summary depending on whether menuNoLink as link or just text
  2. consume that value
  3. tested it to make sure it works (but not a regression test)

This Fix assumes that Issue 432 is even an issue. That may be the case, as it may be an intentional design. In which case ignore this fix.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 0b0fd93b4f28fc69d93894b84667ef2925d503bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR