search

modernweb-dev / web

Guides, tools and libraries for modern web development.
https://modern-web.dev
MIT License
2.21k stars 281 forks source link

helper-libraries.md: mention semantic-dom-diff instead #2665

Closed olleolleolle closed 5 months ago

olleolleolle commented 6 months ago

...instead of the deprecated one.

What I did

  1. I followed the link, saw that the NPM.js page touted the chai plugin in the successor library
  2. Changed the wording, the link
changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: d103a629111450e3acee82d955b828808d92608e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

koddsson commented 5 months ago

Hell yeah, thanks for this <3

olleolleolle commented 5 months ago

@koddsson Come to think of it, I think the chai npm-distributed package DOES offer an import-able ES module? https://modern-web.dev/docs/test-runner/writing-tests/helper-libraries/ claims one needs to use a wrapper module of some sort import { expect } from '@esm-bundle/chai'; - I think this is old news.

koddsson commented 5 months ago

@koddsson Come to think of it, I think the chai npm-distributed package DOES offer an import-able ES module? https://modern-web.dev/docs/test-runner/writing-tests/helper-libraries/ claims one needs to use a wrapper module of some sort import { expect } from '@esm-bundle/chai'; - I think this is old news.

Yeah version 5 of chai is a ES module so we don't need the wrapper anymore.

olleolleolle commented 5 months ago

@koddsson https://github.com/modernweb-dev/web/pull/2716 Thanks!