search

modernweb-dev / web

Guides, tools and libraries for modern web development.
https://modern-web.dev
MIT License
2.15k stars 271 forks source link

js-tests.md: Refer to chai as an ES module #2716

Open olleolleolle opened 2 months ago

olleolleolle commented 2 months ago

Since 5.0, chai is distributed as an ES module, no need for the wrapper.

What I did

  1. I modernized the reference to chai in the example.
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 254148a147ddfd2599fcb26e303a21b441466088

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bashmish commented 2 months ago

There are many more mentions of @esm-bundle/chai in the code. In the documentation should be easy to do that. In the code and tests I think this is a required change too then, also to verify all works with chai 5.x. I think these changes should go as a whole.

olleolleolle commented 2 months ago

@bashmish Thanks! I took a look, learned a little about the structure, and then saw this was too big of a change for me to do without knowing more about the project.

If someone wants to carry this change, be welcome to it!

bashmish commented 2 months ago

I think this is a good first issue. It's impactful, but if chai 5 is compatible, it should be relatively easy to do. This can help to start changing and prepare a PR https://github.com/modernweb-dev/web/blob/master/CONTRIBUTING.md