search

modernweb-dev / web

Guides, tools and libraries for modern web development.
https://modern-web.dev
MIT License
2.15k stars 271 forks source link

Fix rollupAdapter handling of outside-workspace imports #2727

Open justinfagnani opened 1 month ago

justinfagnani commented 1 month ago

Fixes https://github.com/modernweb-dev/web/issues/2231

What I did

  1. Made rollupAdapter correctly take into account rootDir when rewriting outside-of-workspace resolved specifiers.

This PR is a draft because I can't get tests to run locally, and I'm not sure if there's an existing test fixture structure that can express a root dir.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: cb050eb04ae1f305774ffc31fef65cfcaf2dc9f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @web/dev-server-rollup | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR