search

modernweb-dev / web

Guides, tools and libraries for modern web development.
https://modern-web.dev
MIT License
2.15k stars 271 forks source link

fix(storybook-framework-web-components): watch code changes and auto-reload by default #2735

Closed bashmish closed 1 month ago

bashmish commented 1 month ago

What I did

  1. set watch: true to enable auto-reload by default

We implemented the baseline for auto-reload here https://github.com/modernweb-dev/web/pull/2482 But I overlooked the fact that watch: true wasn't set by default. It should be, because it's expected of the Storybook to have this behavior by default, e.g. @storybook/web-components-vite has it.

If we make a stable HMR implementation and test it extensively, we can in the future enable that instead by default (this is what frameworks presets are for, also the one I patch here). For now it's just a simple page reload.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 589bad6cd308317874a6833ea350477b37c55205

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------------------------- | ----- | | @web/storybook-framework-web-components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR