search

modernweb-dev / web

Guides, tools and libraries for modern web development.
https://modern-web.dev
MIT License
2.15k stars 271 forks source link

Fix storybook-builder on Windows #2740

Open bashmish opened 1 month ago

bashmish commented 1 month ago

What I did

  1. setup testing on Windows
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: a137a7043f288299291e610e1918f71c12d2406c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

robrez commented 1 month ago

I encountered the following error today while trying to convert one of my repos to use the builder. Does this PR fix this error?

Storybook failed to load the following preset: @web\storybook-framework-web-components\preset

bashmish commented 1 month ago

@robrez it will, but I'm still busy working on that, today gonna have some focus it's also gonna be solved in Storybook itself, in Storybook 8 to be precise, given they triaged and marked it as bug https://github.com/storybookjs/storybook/issues/27227, but our builder is still on Storybook 7, so for that I'll make a workaround, stay tuned :)

bashmish commented 1 month ago

Unfortunately I can't find a good workaround, so need to wait for Storybook to fix the "preset" issue first. And as a result will park this PR until then.

Meanwhile, you can try using WSL to run Storybook of your project on Windows, it works well (I tested), but it's no suprise given it's just Ubuntu under the hood.