Open talentlessguy opened 2 months ago
changeset-bot[bot]
commented
2 months ago Latest commit: 723ad592a944d19a37f6d877e540911170a73a18
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
bashmish
commented
2 months ago there are pipeline errors, so those are the minimum that such migration need to cover
in general our Storybook pipeline is pretty reliable in testing even such big changes like this PR, but a few things I always needed to check manually, specifically everything related to path resolution, because paths work very differently when you test within a subpackage which is part of a bigger monorepo like modern-web and inside a simple project, also differently when it's an actual published NPM package and when it's a symlink, so I'm afraid I'll need to conduct more tests manually after the pipeline is green
my team has been planning to work on this in this autumn, can't give specific timelines, but sooner than later so we gonna have a closer look into your PR
talentlessguy
commented
2 months ago Thank you for the review, i didnt have historical context of the monorepo, so i will revert some of the changes for unmaintained tools
Also i forgot to tell but this PR is work in progress
based on https://github.com/modernweb-dev/web/pull/2674
What I did