search

modernxmpp / easy-xmpp-invitation

Easy XMPP Invitation Landing Page
MIT License
41 stars 20 forks source link

Random and fixed selection #47

Closed sjehuda closed 5 months ago

sjehuda commented 1 year ago

Select random clients from a given list; limit displayed selection to four items.

sjehuda commented 1 year ago

Fix #27

sjehuda commented 1 year ago

@licaon-kter @pravi should we reduce the displayed clients to three?

Please tell me what do you think?

In the above PR, I've set it to four.

licaon-kter commented 1 year ago

What's the status now? How many are there anyway? :)

sjehuda commented 1 year ago

Currently, each list has 5 clients at most and this page displays a fixed amount of clients, exactly in accord to a given list.

This PR allows us to use an unlimited list and, upon page (re)load, it picks four items out of a given list.

It solves the issue of making the list arbitrary and biased as @pravi correctly pointed out https://github.com/ge0rg/easy-xmpp-invitation/issues/27#issuecomment-1133808987

pravi commented 1 year ago

As long as we recommend well maintained and with good compliance, I don't have much problem how many are there.

sjehuda commented 1 year ago

On Sun, 12 Mar 2023 10:12:02 -0700 Pirate Praveen Arimbrathodiyil @.***> wrote:

As long as we recommend well maintained and with good compliance, I don't have much problem how many are there.

Please look into #48 #49 #50 #51 and feel free to decline or add clients.

Please add a short explanation when you do.

I think your attitude towards this, is good, because we refer to a complete list of software.

ge0rg commented 11 months ago

I'm sorry that I left this without attention for a while. My goal is to have a small curated selection of well-maintained, recommended clients for each platform, not to run this like Microsoft ran the browser-installation popup in older Windows versions. I'd also prefer to have the bundled list sorted by the perceived value.

Except on Android, where yaxim and bruno are a must for personal reasons 😉

I think that having up to four clients per platform is perfectly fine, there is always the link to the full list for a neutral view.

sjehuda commented 11 months ago

I do have an idea for simple customizations; but I'm waiting for this PR to be merged or not merged.

What do you think should we do with this PR?

mwild1 commented 5 months ago

Hey! I'm helping out with reviewing the open PRs on this repo.

What do you think should we do with this PR?

I think the number of clients is not too great to display all at once. Especially after they are filtered by platform.

I do have an idea for simple customizations; but I'm waiting for this PR to be merged or not merged.

I have opened a PR that will make it easier for site owners to add/remove clients in their deployment: #69

With this in mind, I'll close this PR unless there are strong objections. I don't see anyone strongly in favour of random selection.

sjehuda commented 5 months ago

With this in mind, I'll close this PR unless there are strong objections. I don't see anyone strongly in favour of random selection.

Please close this PR. Thank you.