Crash on x86 aka Win32 when querying node end point

[modersohn]

Can be seen running the VCL Demo with Win32 being the target platform.

Crash occurs when calling ts_node_end_point(). ts_node_start_point() does not crash, but does not return the correct location.

Originally TSPoint is defined as

typedef struct TSPoint {
  uint32_t row;
  uint32_t column;
} TSPoint;

which I translated to

  TSPoint = packed record
    row: UInt32;
    column: UInt32;
  end;

This works fine on Win64 where the size of the struct equals the size of a pointer. On Win32 that's not the case.

Calling convention for both APIs is explicitly set to cdecl.

[modersohn]

Links to remember:

• http://rvelthuis.de/articles/articles-dlls.html#structs
• https://docwiki.embarcadero.com/RADStudio/Athens/en/Program_Control_(Delphi)#Handling_Function_Results
• https://stackoverflow.com/questions/45241488/how-does-the-cdecl-calling-convention-returns-a-struct
• https://stackoverflow.com/questions/16119116/passing-record-as-a-function-result-from-delphi-dll-to-c

[modersohn]

Issue still open as the workaround (declaring the function return type as Int64) only works for ts_node_end_point. For ts_node_start_point garbage is returned, which also breaks selection of the code portion. All on Win32 only. Win64 is just fine

[modersohn]

Now fixed by missing cdecl.