search

modery / PowerDocu

Generate technical documentation from your existing Power Automate Flows and Power Apps canvas apps
MIT License
440 stars 73 forks source link

Rubjerg.Graphviz is not compatible with .NET 5, including DLLs manually #4

Closed modery closed 2 years ago

modery commented 3 years ago

As mentioned on https://github.com/Rubjerg/Graphviz.NetWrapper/issues/39, the Rubjerg.Graphviz package is not compatible with .NET 5.0. While its own DLL gets added easily, the GraphViz (and other) DLLs are not added and had to be included manually (see https://github.com/modery/PowerDocu/blob/main/PowerDocu.FlowDocumenter/PowerDocu.FlowDocumenter.csproj)

This seems to be working, but is definitely not a good thing to do. Should be reviewed

chtenb commented 2 years ago

I haven't reproduced your issue, but we now target .netstandard2.0 and test against .net6.0. The nuget tests verify that the dependencies should be copied correctly.

modery commented 2 years ago

I haven't reproduced your issue, but we now target .netstandard2.0 and test against .net6.0. The nuget tests verify that the dependencies should be copied correctly.

Awesome! Will go and check it out soonest, this should make things a lot easier

modery commented 2 years ago

The latest version (1.1.0) is referenced in https://github.com/modery/PowerDocu/commit/480273cdc6597b5992364170c4bf494196d2d5a3, and the DLLs that were included manually have been removed