modesty / pdf2json

converts binary PDF to JSON and text, for server-side PDF processing and command-line use.
https://github.com/modesty/pdf2json
Other
2.02k stars 377 forks source link

Next JS ReferenceError: nodeUtil is not defined #303

Closed ajith-ab closed 6 months ago

ajith-ab commented 1 year ago

Hi all, While trying to parse pdf in NEXT JS throwing following error. Anyone have any idea regarding this.

Screenshot 2023-06-12 at 11 42 45 PM

 {
    "pdf2json": "^3.0.4",
        "next": "13.4.5",
 }

Thanks In Advance
mattb-prg commented 1 year ago

Try adding this to your nextjs config:

const nextConfig = {
  experimental: {
    serverComponentsExternalPackages: ['pdf2json'],
  },
};
OferElfassi commented 1 year ago

It's not the ideal solution, but it works for me. I had the same issue when using this library in the ElectronJs app. I ended up changing each call to nodeUtil.p2j to console.. (warn, error, info, log)

As a result, the library functions as expected, but the  console output is not as nice as it was before. But I disabled console output in production anyway, so it's not a problem for me.

The mofified version can be found here: https://github.com/OferElfassi/pdf2jsonForElectron.git, or you can simply install it using: yarn add https://github.com/OferElfassi/pdf2jsonForElectron.git.

dprothero commented 1 year ago

@OferElfassi I came here with the same issue with Electron! Thanks for sharing your module.

dprothero commented 1 year ago

@OferElfassi your solution builds in Electron, but have you actually successfully run pdf2json from within Electron? I'm trying to run it from the main process and it just hangs, never firing pdfParser_dataReady nor pdfParser_dataError.

const pdfData: PdfData = await new Promise<PdfData>((resolve, reject) => {
  const pdfParser = new PDFParser();
  pdfParser.on("pdfParser_dataError", (errData: unknown) => {
    reject(errData);
  });
  pdfParser.on("pdfParser_dataReady", async (pdfData: PdfData) => {
    resolve(pdfData);
  });
  pdfParser.loadPDF(localPdf);
});

The console output shows as follows:

Load OK: C:\Users\david\Dropbox\DnD\Campaigns\Empire of the Chromatic Conclave\NPCs\zombie-minion.pdf
Warning: Setting up fake worker.
PDF loaded. pagesCount = 1
start to parse page:1
Skipped: tiny fill: 0 x 0

I can run the very same code in a stand-alone node process and it works just fine on the same PDF file with the following output:

Load OK: C:\Users\david\Dropbox\DnD\Campaigns\Empire of the Chromatic Conclave\NPCs\zombie-minion.pdf
Warning: Setting up fake worker.
PDF loaded. pagesCount = 1
start to parse page:1
Skipped: tiny fill: 0 x 0
Success: Page 1
complete parsing page:1

Conspicuously absent fron the Electron debug output are the last two lines showing successful parsing of the page.

So, running it from Electron, it's hanging somewhere in parsing the PDF. 😢

OferElfassi commented 1 year ago

Hey @dprothero im glad my solution helped you. I did use this on the main process in electron, and it worked fine, here is the exact code:

 const extractFromPdf = (pdfPath):Promise<string[]> => {
    return new Promise((resolve, reject) => {
        const pdfParser = new PDFParser();
        pdfParser.on('pdfParser_dataError', errData => {
            console.error(errData)
            reject(errData)
        });
        pdfParser.on('pdfParser_dataReady', pdfData => {
            const processedData = [];
            // ... code to extract text and other content from pdfData ...

            resolve(processedData)
        });
        let dataBuffer = fs.readFileSync(pdfPath);
        pdfParser.parseBuffer(dataBuffer);
    })
}

However, i still had some errors in production, so i ended up using the library as standalone module, outside package.json, you can find the modified version here: https://github.com/OferElfassi/pdf2json_standalone.git you will need to install "@xmldom/xmldom" package as well to make it work. So i copied the folder to my project, and used it like this:

 import PDFParser from "./pdf2json_standalone/pdfparser";
 ... rest of the code is the same as above.

Hope this helps ☺

darklight9811 commented 1 year ago

Try adding this to your nextjs config:

const nextConfig = {
  experimental: {
    serverComponentsExternalPackages: ['pdf2json'],
  },
};

Now it throws the following error:

 ⨯ src\server\generation\index.ts (127:17) @ eval
 ⨯ TypeError: pdf2json__WEBPACK_IMPORTED_MODULE_1__.default is not a constructor
niemal commented 1 year ago

@OferElfassi your solution builds in Electron, but have you actually successfully run pdf2json from within Electron? I'm trying to run it from the main process and it just hangs, never firing pdfParser_dataReady nor pdfParser_dataError.

const pdfData: PdfData = await new Promise<PdfData>((resolve, reject) => {
  const pdfParser = new PDFParser();
  pdfParser.on("pdfParser_dataError", (errData: unknown) => {
    reject(errData);
  });
  pdfParser.on("pdfParser_dataReady", async (pdfData: PdfData) => {
    resolve(pdfData);
  });
  pdfParser.loadPDF(localPdf);
});

The console output shows as follows:

Load OK: C:\Users\david\Dropbox\DnD\Campaigns\Empire of the Chromatic Conclave\NPCs\zombie-minion.pdf
Warning: Setting up fake worker.
PDF loaded. pagesCount = 1
start to parse page:1
Skipped: tiny fill: 0 x 0

I can run the very same code in a stand-alone node process and it works just fine on the same PDF file with the following output:

Load OK: C:\Users\david\Dropbox\DnD\Campaigns\Empire of the Chromatic Conclave\NPCs\zombie-minion.pdf
Warning: Setting up fake worker.
PDF loaded. pagesCount = 1
start to parse page:1
Skipped: tiny fill: 0 x 0
Success: Page 1
complete parsing page:1

Conspicuously absent fron the Electron debug output are the last two lines showing successful parsing of the page.

So, running it from Electron, it's hanging somewhere in parsing the PDF. 😢

I am getting the same behavior on specific PDF files. @dprothero Did you fix it? I am also using the way @OferElfassi suggested, and it works but very rarely without just hanging. Perhaps it's because pdf2json updated their stuff and you need to update the standalone version? I would appreciate it if you took a look!

dprothero commented 1 year ago

@niemal I ran into the same issue... it would work with some PDFs and hang with others.

I switched to pdf-parse-fork and it's been working great.

niemal commented 1 year ago

@niemal I ran into the same issue... it would work with some PDFs and hang with others.

I switched to pdf-parse-fork and it's been working great.

Yeah turns out that's a memory leak and the whole thing is unusable in production. pdf-parse seems to work much more resiliently.

kleenkanteen commented 11 months ago

@niemal how do you know it's a memory leak

jscardona12 commented 11 months ago

@darklight9811 were you able to fix this issue?

modesty commented 6 months ago

please try v3.1.2 please