VDF.write_file() doesn't add data for all stress periods when MT3DRHOFLG=0

dbrakenhoff commented 8 years ago

I was getting end of file errors when attempting to run a seawat model created with Flopy based on an earlier model I received. In this model the MT3DRHOFLG is set to 0 and density is defined per stress period. Kind of wondering what Seawat is calculating if density is fixed for each stress period... But when attempting to play around with the model using Flopy I ran into the following issues:

Turns out Flopy does not add data for every stress period for ITEMS 6 and 7 (INDENSE and DENSE) when writing the VDF package, which it needs when MT3DRHOFLG is set to 0.
Similarly when loading an existing model with a VDF package in which these items were defined per stress period Flopy only reads in DENSE for the very first stress period.

langevin-usgs commented 8 years ago

@dbrakenhoff, you are correct. It looks like this is not supported yet for VDF. I will leave this issue open until I get a chance to add this capability.

langevin-usgs commented 8 years ago

Okay, I think I have this working now. The DENSE array is now a Transient3d object. But I'd like to leave this issue open as this approach also needs to be implemented for the VISC array in the Viscosity Package. Probably also need to do some additional testing on DENSE. @jdhughes-usgs, you should also test your lake examples to make sure they still work with the changes I made to Transient3d.

langevin-usgs commented 8 years ago

@jwhite-usgs, can you take a quick look at the the init method for Transient2d (and 3d). They both set an attribute called cnstst.

    self.cnstst = cnstnt

Is this a typo? I see that you use the following line in t004_test.py:

t2d.cnstnt = 2.0

jwhite-usgs commented 8 years ago

I guess I'm not understanding the problem. It looks like the cnstnt attribute in the constructor of Transient2d and Transient3d not being used - is that the issue? The setitem overloads seem to deal with cnstnt...Let me know what needs to be done.

On Sun, Sep 4, 2016 at 8:12 AM, langevin-usgs notifications@github.com wrote:

@jwhite-usgs https://github.com/jwhite-usgs, can you take a quick look at the the init method for Transient2d (and 3d). They both set an attribute called cnstst.
self.cnstst = cnstnt
Is this a typo? I see that you use the following line in t004_test.py:

t2d.cnstnt = 2.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/modflowpy/flopy/issues/146#issuecomment-244602862, or mute the thread https://github.com/notifications/unsubscribe-auth/AGEwkITRnISiz6YuQZsVvtxR0qMavxL-ks5qmsPIgaJpZM4JwW5Z .

Jeremy White U.S. Geological Survey Texas Water Science Center 1505 Ferguson Lane Austin, Texas 78754 office: 512.927.3585 mobile: 512.550.0621 Email: jwhite@usgs.gov

modflowpy / flopy

VDF.write_file() doesn't add data for all stress periods when MT3DRHOFLG=0 #146