refactor(lgrutil): coerce numpy types to builtins for np2 compat

modflowpy / flopy

A Python package to create, run, and post-process MODFLOW-based models.

https://flopy.readthedocs.io

Other

507 stars 307 forks source link

refactor(lgrutil): coerce numpy types to builtins for np2 compat #2158

Closed wpbonelli closed 5 months ago

wpbonelli commented 5 months ago

test_lgrutil.py fails with numpy>=2.0.0rc1
wrap numpy scalars with float() to avoid loss of precision, per https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
use builtin types in custom output data structures, not mixed builtins and np types — this seems preferable in general, and here in particular for lgr.get_exchange_data()

wpbonelli commented 5 months ago

Numpy migration notes say this is expected for expressions where float32 is combined with the builtin float, this was the only one caught by a test but there are probably more cases where the change in promotion rules leads to slightly different results,. In general it may suffice to relax test comparisons but where we return non-numpy data structures (as here) it seems worth converting any np scalars to builtins for consistency