search

modflowpy / flopy

A Python package to create, run, and post-process MODFLOW-based models.
https://flopy.readthedocs.io
Other
507 stars 307 forks source link

fix(tutorial, verbosity setter): fixed tutorial model name and verbosity setter (#2182) #2193

Closed scottrp closed 3 months ago

scottrp commented 3 months ago

Tutorial01's name was too long for MODFLOW. Additionally, it did not define a top and botm.

Added a verbosity setter that automatically converts numerical verbosity values to the verbosity enumeration value, so that interval values are kept consistent.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.1%. Comparing base (029a4e1) to head (aa05503). Report is 20 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2193 +/- ## ========================================= + Coverage 68.3% 70.1% +1.7% ========================================= Files 260 261 +1 Lines 57947 58232 +285 ========================================= + Hits 39611 40829 +1218 + Misses 18336 17403 -933 ``` | [Files](https://app.codecov.io/gh/modflowpy/flopy/pull/2193?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy) | Coverage Δ | | |---|---|---| | [flopy/mf6/mfsimbase.py](https://app.codecov.io/gh/modflowpy/flopy/pull/2193?src=pr&el=tree&filepath=flopy%2Fmf6%2Fmfsimbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-ZmxvcHkvbWY2L21mc2ltYmFzZS5weQ==) | `61.8% <80.0%> (-0.7%)` | :arrow_down: | ... and [179 files with indirect coverage changes](https://app.codecov.io/gh/modflowpy/flopy/pull/2193/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy)