mwtoews commented 2 years ago

Closes #111

The issue is that the source distribution did not include the build dependencies from pyproject.toml.

This PR does a partial rollback of c370efa28866ce7391a7e8f1d9a14edba6682eec and does two extra checks: build (which would have failed before), and checks the source distribution and wheels using twine.

Note that two files should normally be uploaded to PyPI: a sdist (.tar.gz) and wheels (.whl). This can be done with twine.

codecov[bot] commented 2 years ago

Codecov Report

Merging #113 (f681cd9) into master (c370efa) will decrease coverage by 0.041%. The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #113       +/-   ##
=============================================
- Coverage   62.313%   62.271%   -0.042%     
=============================================
  Files           18        18               
  Lines         4495      4490        -5     
=============================================
- Hits          2801      2796        -5     
  Misses        1694      1694

Impacted Files	Coverage Δ
pymake/autotest/autotest.py	`27.140% <100.000%> (-0.055%)`	:arrow_down:
pymake/utils/download.py	`68.390% <0.000%> (-0.863%)`	:arrow_down:

jdhughes-usgs commented 2 years ago

@mwtoews thanks for the PR

modflowpy / pymake

fix(package build): include pyproject.toml for sdist, add check #113

Codecov Report