Closed frankwillmore closed 1 year ago
@geohang
Merging #117 (90b11ed) into master (8e7ece3) will decrease coverage by
48.251%
. The diff coverage is0.000%
.:exclamation: Current head 90b11ed differs from pull request most recent head 25c7eba. Consider uploading reports for the commit 25c7eba to get more accurate results
@@ Coverage Diff @@
## master #117 +/- ##
==============================================
- Coverage 62.355% 14.103% -48.252%
==============================================
Files 18 17 -1
Lines 4492 4481 -11
==============================================
- Hits 2801 632 -2169
- Misses 1691 3849 +2158
Impacted Files | Coverage Δ | |
---|---|---|
pymake/pymake_base.py | 2.702% <0.000%> (-84.042%) |
:arrow_down: |
pymake/utils/_usgs_src_update.py | 6.353% <0.000%> (-79.006%) |
:arrow_down: |
pymake/utils/_compiler_switches.py | 3.493% <0.000%> (-77.075%) |
:arrow_down: |
pymake/pymake_build_apps.py | 7.272% <0.000%> (-73.637%) |
:arrow_down: |
pymake/utils/_Popen_wrapper.py | 17.500% <0.000%> (-72.500%) |
:arrow_down: |
pymake/utils/_dag.py | 9.729% <0.000%> (-71.892%) |
:arrow_down: |
pymake/utils/_compiler_language_files.py | 7.086% <0.000%> (-67.717%) |
:arrow_down: |
pymake/plot/dependency_graphs.py | 11.688% <0.000%> (-57.143%) |
:arrow_down: |
pymake/pymake.py | 24.074% <0.000%> (-51.852%) |
:arrow_down: |
... and 5 more |
In attempting to build on our system, we identified fc here as containing the entire path to gfortran, which caused the preprocessor directive to be set erroneously as
-fpp
instead ofcpp
. Using the basename solved the issue in our case and would be expected to deliver the correct behavior generally.