search

modflowpy / pymake

Python package for compiling MODFLOW-based applications
https://mfpymake.readthedocs.io/
Other
54 stars 35 forks source link

fix(gsflow): remove gsflow as a possible target #176

Closed jdhughes-usgs closed 4 months ago

jdhughes-usgs commented 4 months ago

gsflow (and prms) cause continual problems trying to include them as prebuilt executables. New versions require additional work to filter out extraneous source files and object files. The build process uses specific compiler flags. In short, supporting gsflow (and prms) requires more support each time we are ready to make a executables release or when a new version is released.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.448%. Comparing base (4460311) to head (55ffaa1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #176 +/- ## ============================================= + Coverage 81.124% 81.448% +0.324% ============================================= Files 20 20 Lines 3523 3466 -57 ============================================= - Hits 2858 2823 -35 + Misses 665 643 -22 ``` | [Files](https://app.codecov.io/gh/modflowpy/pymake/pull/176?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy) | Coverage Δ | | |---|---|---| | [pymake/pymake.py](https://app.codecov.io/gh/modflowpy/pymake/pull/176?src=pr&el=tree&filepath=pymake%2Fpymake.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-cHltYWtlL3B5bWFrZS5weQ==) | `75.964% <ø> (+1.186%)` | :arrow_up: | | [pymake/pymake\_build\_apps.py](https://app.codecov.io/gh/modflowpy/pymake/pull/176?src=pr&el=tree&filepath=pymake%2Fpymake_build_apps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-cHltYWtlL3B5bWFrZV9idWlsZF9hcHBzLnB5) | `87.500% <ø> (+1.413%)` | :arrow_up: | | [pymake/utils/\_compiler\_switches.py](https://app.codecov.io/gh/modflowpy/pymake/pull/176?src=pr&el=tree&filepath=pymake%2Futils%2F_compiler_switches.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-cHltYWtlL3V0aWxzL19jb21waWxlcl9zd2l0Y2hlcy5weQ==) | `78.863% <ø> (-1.397%)` | :arrow_down: | | [pymake/utils/\_usgs\_src\_update.py](https://app.codecov.io/gh/modflowpy/pymake/pull/176?src=pr&el=tree&filepath=pymake%2Futils%2F_usgs_src_update.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy#diff-cHltYWtlL3V0aWxzL191c2dzX3NyY191cGRhdGUucHk=) | `97.771% <ø> (+3.383%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/modflowpy/pymake/pull/176/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=modflowpy)