search

modihere / shortweb

Basic url shortener.
MIT License
15 stars 14 forks source link

Fixed #26 #44

Closed aniketgattani closed 6 years ago

aniketgattani commented 6 years ago

I made the following changes:

  1. Added the input field for alias which is optional
  2. Added the warning message if the alias is assigned to a different url in both views.py and base.html
  3. Removed the qr code whenever the warning messages come.
  4. Corrected the error of clipboard which were occuring earlier in the console.
modihere commented 6 years ago

Will verify and update you soon.

modihere commented 6 years ago

Looks good. But can you just put a limit on the number of characters in alias name? like min 6 and max 7. Or else anything i type is being taken as an alias. And if you reduce the size of the alias box to that of shorten button it will look better. Because 6 characters don't need that much of space. And rather increase the size of dialog which shows the qr code and the shortened URL. Will look much better.